content/browser/devtools/service_worker_devtools_agent_host.h - Issue 1155703003: [DevTools] Inline IPCDevToolsAgentHost into subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/service_worker_devtools_agent_host.h

Issue 1155703003: [DevTools] Inline IPCDevToolsAgentHost into subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | content/browser/devtools/service_worker_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/service_worker_devtools_agent_host.h

diff --git a/content/browser/devtools/service_worker_devtools_agent_host.h b/content/browser/devtools/service_worker_devtools_agent_host.h

index b0535ccfc7f3f28078f0e7120ce21191737769b7..39c00dbe5ac74e80f6181e0091765c8b91cf877e 100644

--- a/content/browser/devtools/service_worker_devtools_agent_host.h

+++ b/content/browser/devtools/service_worker_devtools_agent_host.h

@@ -25,16 +25,15 @@ class ServiceWorkerDevToolsAgentHost : public WorkerDevToolsAgentHost {

void UnregisterWorker();

- // DevToolsAgentHost override.

+ // DevToolsAgentHost overrides.

Type GetType() override;

std::string GetTitle() override;

GURL GetURL() override;

bool Activate() override;

bool Close() override;

- // IPCDevToolsAgentHost override.

- void OnClientAttached(bool reattached) override;

- void OnClientDetached() override;

+ // WorkerDevToolsAgentHost overrides.

+ void OnAttachedStateChanged(bool attached) override;

bool Matches(const ServiceWorkerIdentifier& other);