Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.h

Issue 1155703003: [DevTools] Inline IPCDevToolsAgentHost into subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.h
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.h b/content/browser/devtools/render_frame_devtools_agent_host.h
index a77cdbe2063f4825129d54bf3c21540cf3aa91f7..583c4193f64bcf5758216e1b99411f48bbb14808 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.h
+++ b/content/browser/devtools/render_frame_devtools_agent_host.h
@@ -10,7 +10,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
-#include "content/browser/devtools/ipc_devtools_agent_host.h"
+#include "content/browser/devtools/devtools_agent_host_impl.h"
#include "content/common/content_export.h"
#include "content/public/browser/web_contents_observer.h"
@@ -42,7 +42,7 @@ namespace tracing { class TracingHandler; }
}
class CONTENT_EXPORT RenderFrameDevToolsAgentHost
- : public IPCDevToolsAgentHost,
+ : public DevToolsAgentHostImpl,
private WebContentsObserver {
public:
static void AddAllAgentHosts(DevToolsAgentHost::List* result);
@@ -76,10 +76,11 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
DevToolsAgentHost::List* result,
RenderFrameHost* host);
- // IPCDevToolsAgentHost overrides.
- void SendMessageToAgent(IPC::Message* msg) override;
- void OnClientAttached(bool reattached) override;
- void OnClientDetached() override;
+ // DevToolsAgentHostImpl overrides.
+ void Attach() override;
+ void Detach() override;
+ void InspectElement(int x, int y) override;
+ bool DispatchProtocolMessage(const std::string& message) override;
// WebContentsObserver overrides.
void AboutToNavigateRenderFrame(RenderFrameHost* old_host,
@@ -98,6 +99,9 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
const GURL& url,
ui::PageTransition transition_type) override;
+ void OnClientAttached();
+ void OnClientDetached();
+
void DisconnectRenderFrameHost();
void ConnectRenderFrameHost(RenderFrameHost* rvh);
void ReattachToRenderFrameHost(RenderFrameHost* rvh);
« no previous file with comments | « content/browser/devtools/ipc_devtools_agent_host.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698