Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 1155703003: [DevTools] Inline IPCDevToolsAgentHost into subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_agent_host_impl.h
diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h
index 698bfe90a16d4f489d49e6914a693bc6927daf85..a09c9ebafe760da91b0a50de1bedc72a163d8d50 100644
--- a/content/browser/devtools/devtools_agent_host_impl.h
+++ b/content/browser/devtools/devtools_agent_host_impl.h
@@ -9,6 +9,7 @@
#include "base/compiler_specific.h"
#include "content/common/content_export.h"
+#include "content/common/devtools_messages.h"
#include "content/public/browser/devtools_agent_host.h"
namespace IPC {
@@ -29,9 +30,6 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
// Informs the hosted agent that a client host has detached.
virtual void Detach() = 0;
- // Sends a message to the agent.
- bool DispatchProtocolMessage(const std::string& message) override;
-
// Opens the inspector for this host.
void Inspect(BrowserContext* browser_context);
@@ -45,16 +43,19 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
WebContents* GetWebContents() override;
void DisconnectWebContents() override;
void ConnectWebContents(WebContents* wc) override;
+ bool DispatchProtocolMessage(const std::string& message) override;
protected:
DevToolsAgentHostImpl();
~DevToolsAgentHostImpl() override;
scoped_ptr<DevToolsProtocolHandler> protocol_handler_;
+ std::string state_cookie_;
void set_handle_all_protocol_commands() { handle_all_commands_ = true; }
void HostClosed();
void SendMessageToClient(const std::string& message);
+ void ProcessChunkedMessageFromAgent(const DevToolsMessageChunk& chunk);
static void NotifyCallbacks(DevToolsAgentHostImpl* agent_host, bool attached);
private:
@@ -63,6 +64,8 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
const std::string id_;
DevToolsAgentHostClient* client_;
bool handle_all_commands_;
+ std::string message_buffer_;
+ uint32 message_buffer_size_;
};
} // namespace content
« no previous file with comments | « no previous file | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698