Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.cc

Issue 1155703003: [DevTools] Inline IPCDevToolsAgentHost into subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.cc
diff --git a/content/browser/devtools/devtools_agent_host_impl.cc b/content/browser/devtools/devtools_agent_host_impl.cc
index 4ccb496290c8ec7d9d319cb77ef0fef346933580..dd8f86aa04f13a225066a99706327dd9095e3649 100644
--- a/content/browser/devtools/devtools_agent_host_impl.cc
+++ b/content/browser/devtools/devtools_agent_host_impl.cc
@@ -82,7 +82,8 @@ DevToolsAgentHostImpl::DevToolsAgentHostImpl()
base::Unretained(this)))),
id_(base::GenerateGUID()),
client_(NULL),
- handle_all_commands_(false) {
+ handle_all_commands_(false),
+ message_buffer_size_(0) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
g_instances.Get()[id_] = this;
}
@@ -170,6 +171,35 @@ void DevToolsAgentHostImpl::SendMessageToClient(const std::string& message) {
client_->DispatchProtocolMessage(this, message);
}
+void DevToolsAgentHostImpl::ProcessChunkedMessageFromAgent(
+ const DevToolsMessageChunk& chunk) {
+ if (chunk.is_last && !chunk.post_state.empty())
+ state_cookie_ = chunk.post_state;
+
+ if (chunk.is_first && chunk.is_last) {
+ CHECK(message_buffer_size_ == 0);
+ SendMessageToClient(chunk.data);
+ return;
+ }
+
+ if (chunk.is_first) {
+ message_buffer_ = std::string();
+ message_buffer_.reserve(chunk.message_size);
+ message_buffer_size_ = chunk.message_size;
+ }
+
+ CHECK(message_buffer_.size() + chunk.data.size() <=
+ message_buffer_size_);
+ message_buffer_.append(chunk.data);
+
+ if (chunk.is_last) {
+ CHECK(message_buffer_.size() == message_buffer_size_);
+ SendMessageToClient(message_buffer_);
+ message_buffer_ = std::string();
+ message_buffer_size_ = 0;
+ }
+}
+
// static
void DevToolsAgentHost::DetachAllClients() {
if (g_instances == NULL)
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.h ('k') | content/browser/devtools/ipc_devtools_agent_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698