Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1155703003: [DevTools] Inline IPCDevToolsAgentHost into subclasses. (Closed)

Created:
5 years, 7 months ago by dgozman
Modified:
5 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Inline IPCDevToolsAgentHost into subclasses. BUG=none Committed: https://crrev.com/0a5834c562d3455f3e70c50506453d19170e0b51 Cr-Commit-Position: refs/heads/master@{#331583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -188 lines) Patch
M content/browser/devtools/devtools_agent_host_impl.h View 4 chunks +6 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 2 chunks +31 lines, -1 line 0 comments Download
D content/browser/devtools/ipc_devtools_agent_host.h View 1 chunk +0 lines, -44 lines 0 comments Download
D content/browser/devtools/ipc_devtools_agent_host.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 4 chunks +10 lines, -6 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +39 lines, -8 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_agent_host.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_agent_host.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.h View 4 chunks +11 lines, -11 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 5 chunks +30 lines, -20 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
5 years, 7 months ago (2015-05-27 14:58:31 UTC) #2
pfeldman
lgtm
5 years, 7 months ago (2015-05-27 15:01:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155703003/1
5 years, 7 months ago (2015-05-27 15:04:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 16:06:03 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 16:07:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a5834c562d3455f3e70c50506453d19170e0b51
Cr-Commit-Position: refs/heads/master@{#331583}

Powered by Google App Engine
This is Rietveld 408576698