Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 11557029: Add UTF-8 BOM for chrome_messages_json formatter. (Closed)

Created:
8 years ago by Sergey Ulanov
Modified:
8 years ago
Reviewers:
garykac, Jói
CC:
grit-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@conditions
Visibility:
Public.

Description

Add UTF-8 BOM for chrome_messages_json formatter. When uploading extension Chrome Web Store currently expects to find BOM in UTF-8 files. Committed: https://code.google.com/p/grit-i18n/source/detail?r=91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M grit/tool/build.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sergey Ulanov
http://youtu.be/IzowSs9mNOM
8 years ago (2012-12-13 02:12:24 UTC) #1
Jói
8 years ago (2012-12-13 10:24:54 UTC) #2
LGTM. utf-8-sig is da bomb ;-)

Powered by Google App Engine
This is Rietveld 408576698