Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: utils/pub/validator/pubspec_field.dart

Issue 11557008: Make pub publish more user friendly: (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merge in path changes. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/validator/name.dart ('k') | utils/tests/pub/directory_tree_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/validator/pubspec_field.dart
diff --git a/utils/pub/validator/pubspec_field.dart b/utils/pub/validator/pubspec_field.dart
index e7e8ca733821bbe5c8bda3e1998e6dfa1e7b2125..17ddc279c7a625496fbb7e7d8514a39584188085 100644
--- a/utils/pub/validator/pubspec_field.dart
+++ b/utils/pub/validator/pubspec_field.dart
@@ -7,6 +7,7 @@ library pubspec_field_validator;
import '../entrypoint.dart';
import '../system_cache.dart';
import '../validator.dart';
+import '../version.dart';
/// A validator that checks that the pubspec has valid "author" and "homepage"
/// fields.
@@ -20,7 +21,7 @@ class PubspecFieldValidator extends Validator {
var author = pubspec.fields['author'];
var authors = pubspec.fields['authors'];
if (author == null && authors == null) {
- errors.add('pubspec.yaml is missing an "author" or "authors" field.');
+ errors.add('Your pubspec.yaml must have an "author" or "authors" field.');
} else {
if (authors == null) authors = [author];
@@ -28,24 +29,29 @@ class PubspecFieldValidator extends Validator {
var hasEmail = new RegExp(r"<[^>]+> *$");
for (var authorName in authors) {
if (!hasName.hasMatch(authorName)) {
- warnings.add('Author "$authorName" in pubspec.yaml is missing a '
+ warnings.add('Author "$authorName" in pubspec.yaml should have a '
'name.');
}
if (!hasEmail.hasMatch(authorName)) {
- warnings.add('Author "$authorName" in pubspec.yaml is missing an '
- 'email address (e.g. "name <email>").');
+ warnings.add('Author "$authorName" in pubspec.yaml should have an '
+ 'email address\n(e.g. "name <email>").');
}
}
}
var homepage = pubspec.fields['homepage'];
if (homepage == null) {
- errors.add('pubspec.yaml is missing a "homepage" field.');
+ errors.add('Your pubspec.yaml is missing a "homepage" field.');
}
var description = pubspec.fields['description'];
if (description == null) {
- errors.add('pubspec.yaml is missing a "description" field.');
+ errors.add('Your pubspec.yaml is missing a "description" field.');
+ }
+
+ var version = pubspec.fields['version'];
+ if (version == null) {
+ errors.add('Your pubspec.yaml is missing a "version" field.');
}
return new Future.immediate(null);
« no previous file with comments | « utils/pub/validator/name.dart ('k') | utils/tests/pub/directory_tree_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698