runtime/lib/bool_patch.dart - Issue 11557002: Added bool.hashCode patch.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/bool_patch.dart

Issue 11557002: Added bool.hashCode patch. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 // Dart core library.

	6

	7 patch class bool {

	8

	9 /* patch */ int get hashCode {

	10 return this ? 1231 : 1237;

	11 }

	12 // Object.equals is fine, since true and false are singletons.
	cshapiro 2012/12/12 00:35:13 Presumably, this is defaulting to some sort of is- Presumably, this is defaulting to some sort of is-same-object equals method? Is there any harm in putting in an equals method? srdjan 2012/12/12 00:55:25 Object's equal calls identical. AFAIK, compiler h Show quoted text On 2012/12/12 00:35:13, cshapiro wrote: > Presumably, this is defaulting to some sort of is-same-object equals method? Is > there any harm in putting in an equals method? Object's equal calls identical. AFAIK, compiler has optimizations where it recognizes that equal was not overriden, therefore I would not replicate code here.
	13 }

OLD	NEW

« no previous file with comments | « no previous file | runtime/lib/lib_sources.gypi » ('j') | no next file with comments »