Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: sky/sdk/lib/framework/components2/popup_menu_item.dart

Issue 1155683011: Add |constraints| to Container for PopupMenuItem (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/sdk/lib/framework/fn2.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/popup_menu_item.dart
diff --git a/sky/sdk/lib/framework/components2/popup_menu_item.dart b/sky/sdk/lib/framework/components2/popup_menu_item.dart
index 8f7076c7be446d5d4067e348cec452d66cee3a45..942f0ebd7ffde8f4b69da96052cfa0085c49b093 100644
--- a/sky/sdk/lib/framework/components2/popup_menu_item.dart
+++ b/sky/sdk/lib/framework/components2/popup_menu_item.dart
@@ -6,21 +6,17 @@ import '../fn2.dart';
import 'ink_well.dart';
class PopupMenuItem extends Component {
- static final Style _style = new Style('''
- min-width: 112px;
- padding: 16px;''');
-
List<UINode> children;
double opacity;
PopupMenuItem({ Object key, this.children, this.opacity}) : super(key: key);
UINode build() {
- return new StyleNode(
- new InkWell(
- inlineStyle: opacity == null ? null : 'opacity: ${opacity}',
- children: children
- ),
- _style);
+ return new Container(
+ constraints: const BoxConstraints(minWidth: 112.0),
+ padding: const EdgeDims.all(16.0),
+ // TODO(abarth): opacity: opacity,
+ child: new InkWell(children: children)
+ );
}
}
« no previous file with comments | « no previous file | sky/sdk/lib/framework/fn2.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698