Issue 1155683011: Add |constraints| to Container for PopupMenuItem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1155683011: Add |constraints| to Container for PopupMenuItem (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add |constraints| to Container for PopupMenuItem This CL is the first step towards getting PopupMenuItem working in fn2. We introduce the ability to add a minWidth to a Container by creating a RenderConstrainedBox class to apply the new constraints. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2ae6e5683720094f285026849432cde78d961f9e

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -19 lines)			Patch
M	sky/sdk/lib/framework/components2/popup_menu_item.dart	View	1 chunk	+6 lines, -10 lines	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View	4 chunks	+27 lines, -7 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	3 chunks	+45 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-08 19:22:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2ae6e5683720094f285026849432cde78d961f9e (presubmit successful).