Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: src/ppc/assembler-ppc.cc

Issue 1155673005: Fix issues with Arm's use of embedded constant pools (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move DataAlign implementation to common code Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ppc/assembler-ppc.h ('k') | src/ppc/assembler-ppc-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ppc/assembler-ppc.cc
diff --git a/src/ppc/assembler-ppc.cc b/src/ppc/assembler-ppc.cc
index cce578e9f6cde0c2519afdf5d72311a2b64668ce..38c7fd82b7bbe096725621d39a531f973491ed80 100644
--- a/src/ppc/assembler-ppc.cc
+++ b/src/ppc/assembler-ppc.cc
@@ -244,17 +244,9 @@ void Assembler::GetCode(CodeDesc* desc) {
void Assembler::Align(int m) {
-#if V8_TARGET_ARCH_PPC64
- DCHECK(m >= 4 && base::bits::IsPowerOfTwo64(m));
-#else
DCHECK(m >= 4 && base::bits::IsPowerOfTwo32(m));
-#endif
- // First ensure instruction alignment
- while (pc_offset() & (kInstrSize - 1)) {
- db(0);
- }
- // Then pad to requested alignedment with nops
- while (pc_offset() & (m - 1)) {
+ DCHECK((pc_offset() & (kInstrSize - 1)) == 0);
+ while ((pc_offset() & (m - 1)) != 0) {
nop();
}
}
« no previous file with comments | « src/ppc/assembler-ppc.h ('k') | src/ppc/assembler-ppc-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698