src/arm/assembler-arm.cc - Issue 1155673005: Fix issues with Arm's use of embedded constant pools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/assembler-arm.cc

Issue 1155673005: Fix issues with Arm's use of embedded constant pools (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Move DataAlign implementation to common code Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/assembler-arm.cc

diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc

index ed8664a9c5f32f10ddc131ad8973e2b79cc37347..b90ff1e05b6a383cbf40276af1e762b20ebd2635 100644

--- a/src/arm/assembler-arm.cc

+++ b/src/arm/assembler-arm.cc

@@ -494,6 +494,7 @@ void Assembler::GetCode(CodeDesc* desc) {

void Assembler::Align(int m) {

DCHECK(m >= 4 && base::bits::IsPowerOfTwo32(m));

+ DCHECK((pc_offset() & (kInstrSize - 1)) == 0);

while ((pc_offset() & (m - 1)) != 0) {

nop();

}

« no previous file with comments | « src/arm/assembler-arm.h ('k') | src/arm/assembler-arm-inl.h » ('j') | no next file with comments »