Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/x87/assembler-x87.h

Issue 1155673005: Fix issues with Arm's use of embedded constant pools (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move DataAlign implementation to common code Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 572 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 // is: should we always use Operands instead of Registers where an 583 // is: should we always use Operands instead of Registers where an
584 // Operand is possible, or should we have a Register (overloaded) form 584 // Operand is possible, or should we have a Register (overloaded) form
585 // instead? We must be careful to make sure that the selected instruction 585 // instead? We must be careful to make sure that the selected instruction
586 // is obvious from the parameters to avoid hard-to-find code generation 586 // is obvious from the parameters to avoid hard-to-find code generation
587 // bugs. 587 // bugs.
588 588
589 // Insert the smallest number of nop instructions 589 // Insert the smallest number of nop instructions
590 // possible to align the pc offset to a multiple 590 // possible to align the pc offset to a multiple
591 // of m. m must be a power of 2. 591 // of m. m must be a power of 2.
592 void Align(int m); 592 void Align(int m);
593 // Insert the smallest number of zero bytes possible to align the pc offset
594 // to a mulitple of m. m must be a power of 2 (>= 2).
595 void DataAlign(int m);
593 void Nop(int bytes = 1); 596 void Nop(int bytes = 1);
594 // Aligns code to something that's optimal for a jump target for the platform. 597 // Aligns code to something that's optimal for a jump target for the platform.
595 void CodeTargetAlign(); 598 void CodeTargetAlign();
596 599
597 // Stack 600 // Stack
598 void pushad(); 601 void pushad();
599 void popad(); 602 void popad();
600 603
601 void pushfd(); 604 void pushfd();
602 void popfd(); 605 void popfd();
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
1080 private: 1083 private:
1081 Assembler* assembler_; 1084 Assembler* assembler_;
1082 #ifdef DEBUG 1085 #ifdef DEBUG
1083 int space_before_; 1086 int space_before_;
1084 #endif 1087 #endif
1085 }; 1088 };
1086 1089
1087 } } // namespace v8::internal 1090 } } // namespace v8::internal
1088 1091
1089 #endif // V8_X87_ASSEMBLER_X87_H_ 1092 #endif // V8_X87_ASSEMBLER_X87_H_
OLDNEW
« no previous file with comments | « src/x64/assembler-x64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698