Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1155673004: Made matchedResult method const. (Closed)

Created:
5 years, 6 months ago by rune
Modified:
5 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Bleh. Use const in the implementation too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/css/ElementRuleCollector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
rune
Constness as requested in https://codereview.chromium.org/1155393002/#msg7
5 years, 6 months ago (2015-06-02 09:32:19 UTC) #1
mstensho (USE GERRIT)
lgtm
5 years, 6 months ago (2015-06-02 09:34:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155673004/1
5 years, 6 months ago (2015-06-02 09:34:44 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/46167)
5 years, 6 months ago (2015-06-02 09:49:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155673004/20001
5 years, 6 months ago (2015-06-02 10:41:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64784)
5 years, 6 months ago (2015-06-02 13:52:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155673004/20001
5 years, 6 months ago (2015-06-02 14:11:30 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 15:22:50 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196320

Powered by Google App Engine
This is Rietveld 408576698