chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm - Issue 1155673002: Omnibox - Add About Flag to Reverse Title and URLs in the Dropdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

Issue 1155673002: Omnibox - Add About Flag to Reverse Title and URLs in the Dropdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac and add command line flag to histograms.xml Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

index 63657b0aca1a4c15c4506797f51f5691b234aca5..9a74bc66bbd8304f333fffc3dcab94c86910617b 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

@@ -10,6 +10,7 @@

#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"

#import "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"

#include "chrome/test/base/testing_profile.h"

+#include "components/omnibox/autocomplete_input.h"

#include "ui/gfx/font_list.h"

#include "ui/gfx/geometry/rect.h"

#include "ui/gfx/text_elider.h"

@@ -29,7 +30,7 @@ class MockOmniboxPopupViewMac : public OmniboxPopupViewMac {

for (size_t i = 0; i < count; ++i)

matches.push_back(AutocompleteMatch());

result_.Reset();

- result_.AppendMatches(matches);

+ result_.AppendMatches(AutocompleteInput(), matches);

}

protected:

« no previous file with comments | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | chrome/browser/ui/omnibox/omnibox_edit_model.cc » ('j') | no next file with comments »