Omnibox - Add About Flag to Reverse Title and URLs in the Dropdown

components/omnibox/autocomplete_result.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OMNIBOX_AUTOCOMPLETE_RESULT_H_
 #define COMPONENTS_OMNIBOX_AUTOCOMPLETE_RESULT_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 51 matching lines @@
 
   AutocompleteResult();
   ~AutocompleteResult();
 
   // Copies matches from |old_matches| to provide a consistant result set. See
   // comments in code for specifics.
   void CopyOldMatches(const AutocompleteInput& input,
                       const AutocompleteResult& old_matches,
                       TemplateURLService* template_url_service);
 
-  // Adds a new set of matches to the result set.  Does not re-sort.
-  void AppendMatches(const ACMatches& matches);
+  // Adds a new set of matches to the result set.  Does not re-sort.  May
+  // transform the matches while adding them to make them better fit with the
+  // result set.  Whether the transformation happens and how it does can
+  // change depending on |input|.

[Peter Kasting, 2015/05/22 23:39:36]

Nit: These last two sentences are vague.  I'd just say something like "Calls
PossiblySwapContentsAndDescriptionForURLSuggestion(input)" on all added matches;
see comments there for more information."

[Mark P, 2015/05/23 20:32:13]

I slightly prefer the vagueness because I want to make the larger point that
matches in AutocompleteResult can be transformed in arbitrary ways.  Yet, I see
your point that it's not necessary to make the larger point when the smaller,
more-exact point will do for now.  Revised as you suggested.

+  void AppendMatches(const AutocompleteInput& input,
+                     const ACMatches& matches);
 
   // Removes duplicates, puts the list in sorted order and culls to leave only
   // the best kMaxMatches matches.  Sets the default match to the best match
   // and updates the alternate nav URL.
   void SortAndCull(const AutocompleteInput& input,
                    TemplateURLService* template_url_service);
 
   // Returns true if at least one match was copied from the last result.
   bool HasCopiedMatches() const;
 
@@ skipping 112 matching lines @@
   // user's local intranet contains site "foo", and the user types "foo", we
   // default to searching for "foo" when the user may have meant to navigate
   // there.  In cases like this, the default match will point to the "search for
   // 'foo'" result, and this will contain "http://foo/".
   GURL alternate_nav_url_;
 
   DISALLOW_COPY_AND_ASSIGN(AutocompleteResult);
 };
 
 #endif  // COMPONENTS_OMNIBOX_AUTOCOMPLETE_RESULT_H_