Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart

Issue 1155633002: Fix 56 hints in pkg/compiler (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/string_validator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart
diff --git a/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart b/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart
index c8cfebc91b45293457c033c1b59d729945acb2be..dbc5e5f1927777336c87930863b8b1c69104f103 100644
--- a/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart
+++ b/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart
@@ -142,7 +142,6 @@ class BitNotSpecializer extends InvokeDynamicSpecializer {
HInstruction tryConvertToBuiltin(HInvokeDynamic instruction,
Compiler compiler) {
- JavaScriptBackend backend = compiler.backend;
HInstruction input = instruction.inputs[1];
if (input.isNumber(compiler)) {
return new HBitNot(input, instruction.selector,
@@ -417,7 +416,6 @@ class TruncatingDivideSpecializer extends BinaryArithmeticSpecializer {
HInstruction tryConvertToBuiltin(HInvokeDynamic instruction,
Compiler compiler) {
- HInstruction left = instruction.inputs[1];
HInstruction right = instruction.inputs[2];
if (isBuiltin(instruction, compiler)) {
if (right.isPositiveInteger(compiler) && isNotZero(right, compiler)) {
@@ -491,7 +489,6 @@ class ShiftLeftSpecializer extends BinaryBitOpSpecializer {
// the instruction does not have any side effect, and that it
// can be GVN'ed.
clearAllSideEffects(instruction);
- Selector selector = instruction.selector;
if (isPositive(right, compiler)) {
instruction.selector = renameToOptimizedSelector(
'_shlPositive', instruction.selector, compiler);
@@ -502,7 +499,6 @@ class ShiftLeftSpecializer extends BinaryBitOpSpecializer {
HInstruction newBuiltinVariant(HInvokeDynamic instruction,
Compiler compiler) {
- JavaScriptBackend backend = compiler.backend;
return new HShiftLeft(
instruction.inputs[1], instruction.inputs[2],
instruction.selector, computeTypeFromInputTypes(instruction, compiler));
@@ -515,8 +511,6 @@ class ShiftRightSpecializer extends BinaryBitOpSpecializer {
TypeMask computeTypeFromInputTypes(HInvokeDynamic instruction,
Compiler compiler) {
HInstruction left = instruction.inputs[1];
- HInstruction right = instruction.inputs[2];
- JavaScriptBackend backend = compiler.backend;
if (left.isUInt32(compiler)) return left.instructionType;
return super.computeTypeFromInputTypes(instruction, compiler);
}
@@ -549,7 +543,6 @@ class ShiftRightSpecializer extends BinaryBitOpSpecializer {
HInstruction newBuiltinVariant(HInvokeDynamic instruction,
Compiler compiler) {
- JavaScriptBackend backend = compiler.backend;
return new HShiftRight(
instruction.inputs[1], instruction.inputs[2],
instruction.selector, computeTypeFromInputTypes(instruction, compiler));
@@ -580,7 +573,6 @@ class BitOrSpecializer extends BinaryBitOpSpecializer {
HInstruction newBuiltinVariant(HInvokeDynamic instruction,
Compiler compiler) {
- JavaScriptBackend backend = compiler.backend;
return new HBitOr(
instruction.inputs[1], instruction.inputs[2],
instruction.selector, computeTypeFromInputTypes(instruction, compiler));
@@ -608,7 +600,6 @@ class BitAndSpecializer extends BinaryBitOpSpecializer {
HInstruction newBuiltinVariant(HInvokeDynamic instruction,
Compiler compiler) {
- JavaScriptBackend backend = compiler.backend;
return new HBitAnd(
instruction.inputs[1], instruction.inputs[2],
instruction.selector, computeTypeFromInputTypes(instruction, compiler));
@@ -635,7 +626,6 @@ class BitXorSpecializer extends BinaryBitOpSpecializer {
HInstruction newBuiltinVariant(HInvokeDynamic instruction,
Compiler compiler) {
- JavaScriptBackend backend = compiler.backend;
return new HBitXor(
instruction.inputs[1], instruction.inputs[2],
instruction.selector, computeTypeFromInputTypes(instruction, compiler));
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/string_validator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698