pkg/compiler/lib/src/source_file_provider.dart - Issue 1155633002: Fix 56 hints in pkg/compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/source_file_provider.dart

Issue 1155633002: Fix 56 hints in pkg/compiler (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/source_file_provider.dart

diff --git a/pkg/compiler/lib/src/source_file_provider.dart b/pkg/compiler/lib/src/source_file_provider.dart

index d0bd1b9de54cb5338660fc08bbda07d926f25c6f..30a75591734d35524c7e8167cf900c23cb4b5f3a 100644

--- a/pkg/compiler/lib/src/source_file_provider.dart

+++ b/pkg/compiler/lib/src/source_file_provider.dart

@@ -22,7 +22,7 @@ List<int> readAll(String filename) {

var length = file.lengthSync();

// +1 to have a 0 terminated list, see [Scanner].

var buffer = new Uint8List(length + 1);

- var bytes = file.readIntoSync(buffer, 0, length);

+ file.readIntoSync(buffer, 0, length);

file.closeSync();

return buffer;

}