pkg/compiler/lib/src/js_backend/codegen/codegen.dart - Issue 1155633002: Fix 56 hints in pkg/compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1155633002: Fix 56 hints in pkg/compiler (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

index 45d75902e0c0b1a9e35f5e6fc740f5faacbaf32d..922173eb75cc5da2bb7ee96cfc8669b03d358621 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart

@@ -306,7 +306,6 @@ class CodeGenerator extends tree_ir.StatementVisitor

@override

js.Expression visitLiteralList(tree_ir.LiteralList node) {

registry.registerInstantiatedClass(glue.listClass);

- int length = node.values.length;

List<js.Expression> entries = node.values.map(visitExpression).toList();

return new js.ArrayInitializer(entries);

}