pkg/compiler/lib/src/scanner/parser_task.dart - Issue 1155633002: Fix 56 hints in pkg/compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/scanner/parser_task.dart

Issue 1155633002: Fix 56 hints in pkg/compiler (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/scanner/parser_task.dart

diff --git a/pkg/compiler/lib/src/scanner/parser_task.dart b/pkg/compiler/lib/src/scanner/parser_task.dart

index af9a013ee54851e2477d638cfeffabcb9a9216c1..e1675f9d22a66448661b53847eba59d2fa252104 100644

--- a/pkg/compiler/lib/src/scanner/parser_task.dart

+++ b/pkg/compiler/lib/src/scanner/parser_task.dart

@@ -18,7 +18,7 @@ class ParserTask extends CompilerTask {

Parser parser = new Parser(listener);

try {

parser.parseUnit(token);

- } on ParserError catch (e) {

Siggi Cherem (dart-lang) 2015/05/22 03:20:21 Weird - I didn't know the "catch" was optional her

Johnni Winther 2015/05/22 07:37:57 Neither did I nor dart2js. Leave these in and file

kevmoo 2015/05/22 15:39:02 Done https://code.google.com/p/dart/issues/detail

+ } on ParserError {

assert(invariant(token, compiler.compilationFailed));

return listener.makeNodeList(0, null, null, '\n');

}