Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2583)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 1155633002: Fix 56 hints in pkg/compiler (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/dart2js.dart » ('j') | pkg/compiler/lib/src/dump_info.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 6d8b6d0bee49ea805822bed401e8143ebc228862..8046c5b9642602cbbee9dfb6e16ffa05e849ea80 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -909,7 +909,7 @@ abstract class Compiler implements DiagnosticListener {
}
hasCrashed = true;
rethrow;
- } on StackOverflowError catch (ex) {
+ } on StackOverflowError {
// We cannot report anything useful in this case, because we
// do not have enough stack space.
rethrow;
@@ -1763,9 +1763,7 @@ abstract class Compiler implements DiagnosticListener {
resolved.remove(e);
}
if (identical(e.kind, ElementKind.GENERATIVE_CONSTRUCTOR)) {
- ClassElement enclosingClass = e.enclosingClass;
resolved.remove(e);
-
}
if (backend.isBackendLibrary(e.library)) {
resolved.remove(e);
@@ -1901,7 +1899,6 @@ abstract class Compiler implements DiagnosticListener {
void reportAssertionFailure(SpannableAssertionFailure ex) {
String message = (ex.message != null) ? tryToString(ex.message)
: tryToString(ex);
- SourceSpan span = spanFromSpannable(ex.node);
reportDiagnosticInternal(
ex.node, MessageKind.GENERIC, {'text': message}, api.Diagnostic.CRASH);
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/dart2js.dart » ('j') | pkg/compiler/lib/src/dump_info.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698