Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1155593002: Move GrPath(Range) creation to ResourceProvider. (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrPath(Range) creation to ResourceProvider. Committed: https://skia.googlesource.com/skia/+/706f08fbcb7f5275235784f67bd7d188ad04eef2

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -55 lines) Patch
M src/gpu/GrAddPathRenderers_default.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M src/gpu/GrResourceProvider.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.h View 1 chunk +27 lines, -29 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 5 chunks +14 lines, -23 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
bsalomon
5 years, 7 months ago (2015-05-21 19:02:52 UTC) #2
robertphillips
lgtm
5 years, 7 months ago (2015-05-21 19:10:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155593002/1
5 years, 7 months ago (2015-05-21 19:38:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/1008) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 7 months ago (2015-05-21 19:39:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155593002/20001
5 years, 7 months ago (2015-05-21 20:03:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1199)
5 years, 7 months ago (2015-05-21 20:05:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155593002/40001
5 years, 7 months ago (2015-05-21 20:28:47 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_TIMED_OUT, no build URL)
5 years, 7 months ago (2015-05-21 22:29:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155593002/40001
5 years, 7 months ago (2015-05-22 14:35:26 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 14:36:03 UTC) #21
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/706f08fbcb7f5275235784f67bd7d188ad04eef2

Powered by Google App Engine
This is Rietveld 408576698