Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: sky/tools/skydb

Issue 1155583006: Make skydb --gdb work on mac. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/mojo_cache_linker.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/skydb
diff --git a/sky/tools/skydb b/sky/tools/skydb
index faac8bac7c0dec18c8e9ca679836410bfe045b43..e99509d762c849ddd4424a4e3ab572c837b603c9 100755
--- a/sky/tools/skydb
+++ b/sky/tools/skydb
@@ -18,6 +18,7 @@ import subprocess
import sys
import time
import urlparse
+import platform
SUPPORTED_MIME_TYPES = [
'text/html',
@@ -531,9 +532,14 @@ class SkyDebugger(object):
symbol_search_paths = system_lib_dirs + symbol_search_paths
# TODO(eseidel): We need to look up the toolchain somehow?
- gdb_path = os.path.join(SRC_ROOT, 'third_party/android_tools/ndk/'
- 'toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/'
- 'bin/arm-linux-androideabi-gdb')
+ if platform.system() == 'Darwin':
+ gdb_path = os.path.join(SRC_ROOT, 'third_party/android_tools/ndk/'
+ 'toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64/'
+ 'bin/arm-linux-androideabi-gdb')
+ else:
+ gdb_path = os.path.join(SRC_ROOT, 'third_party/android_tools/ndk/'
+ 'toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/'
+ 'bin/arm-linux-androideabi-gdb')
# Set solib-search-path after letting android modify symbol_search_paths
eval_commands.append(
« no previous file with comments | « sky/tools/mojo_cache_linker.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698