Source/modules/cachestorage/CacheStorageError.cpp - Issue 1155573003: CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/cachestorage/CacheStorageError.cpp

Issue 1155573003: CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/cachestorage/CacheStorageError.cpp

diff --git a/Source/modules/cachestorage/CacheStorageError.cpp b/Source/modules/cachestorage/CacheStorageError.cpp

index 13ccc6fe670765806c2aeb20e4ab1d0defb096c1..ca15d2f74dd692d13f0512c07999cdba090ad751 100644

--- a/Source/modules/cachestorage/CacheStorageError.cpp

+++ b/Source/modules/cachestorage/CacheStorageError.cpp

@@ -19,6 +19,9 @@ DOMException* CacheStorageError::take(ScriptPromiseResolver*, WebType* webErrorR

void CacheStorageError::dispose(WebType* webErrorRaw)

{

+#ifdef CRBUG_494884

+ delete webErrorRaw;

+#endif

}

DOMException* CacheStorageError::createException(WebType webError)

« Source/modules/cachestorage/Cache.cpp ('K') | « Source/modules/cachestorage/CacheStorage.cpp ('k') | public/platform/WebServiceWorkerCacheError.h » ('j') | no next file with comments »