Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1155543007: Revert 196325 "Make small-caps work correctly with tr locale" (Closed)

Created:
5 years, 6 months ago by Justin Novosad
Modified:
5 years, 6 months ago
Reviewers:
rwlbuis
CC:
blink-reviews
Visibility:
Public.

Description

Revert 196325 "Make small-caps work correctly with tr locale" Reason for revert: ASAN detected a buffer overflow The layout test small-caps-turkish.html is flaky, possibly due to the overflow https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_ASAN/18816/layout-test-results/fast/text/small-caps-turkish-crash-log.txt > Make small-caps work correctly with tr locale > > We correctly support tr upper/lower casing rules > for Strings through StringImpl::lower/upper methods > that take a locale parameter. However for upper/lowering > case for single Char32, which the small-caps code > path uses, there is no such overload, so add that to wtf. > > Behavior matches Firefox. > > BUG=395369 > > Review URL: https://codereview.chromium.org/1135003004 TBR=rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196344

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
Justin Novosad
5 years, 6 months ago (2015-06-02 20:43:13 UTC) #1
Justin Novosad
5 years, 6 months ago (2015-06-02 20:43:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r196344.

Powered by Google App Engine
This is Rietveld 408576698