Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1155543003: [turbofan] Optimized lowering of DYNAMIC_LOCAL lookup slot loads. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimized lowering of DYNAMIC_LOCAL lookup slot loads. This adds handling of JSLoadDynamicContext nodes to JSTypedLowering to perform extension checks and an inline fast path. The fast path is a context slot load targeting a specific context. R=bmeurer@chromium.org BUG=v8:4131 LOG=N Committed: https://crrev.com/5ca1f24dd51fb2b3202dda4ee23a7b833dd352a9 Cr-Commit-Position: refs/heads/master@{#28823}

Patch Set 1 #

Patch Set 2 : Fix missing check. #

Total comments: 2

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -2 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 2 chunks +59 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-02 13:17:09 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/1155543003/diff/20001/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1155543003/diff/20001/src/compiler/js-typed-lowering.cc#newcode1003 src/compiler/js-typed-lowering.cc:1003: Node* check = graph()->NewNode(simplified()->ObjectIsSmi(), load); We can use ReferenceEqual ...
5 years, 6 months ago (2015-06-03 03:46:53 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1155543003/diff/20001/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1155543003/diff/20001/src/compiler/js-typed-lowering.cc#newcode1003 src/compiler/js-typed-lowering.cc:1003: Node* check = graph()->NewNode(simplified()->ObjectIsSmi(), load); On 2015/06/03 03:46:52, Benedikt ...
5 years, 6 months ago (2015-06-03 08:45:00 UTC) #3
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-08 08:18:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155543003/40001
5 years, 6 months ago (2015-06-08 08:18:37 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-08 08:59:05 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 08:59:12 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ca1f24dd51fb2b3202dda4ee23a7b833dd352a9
Cr-Commit-Position: refs/heads/master@{#28823}

Powered by Google App Engine
This is Rietveld 408576698