Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1155543002: ozone: Use DeviceCapabilities in TabletEventConverterEvdev unittest (Closed)

Created:
5 years, 7 months ago by robert.bradford
Modified:
5 years, 7 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Use DeviceCapabilities in TabletEventConverterEvdev unittest This change enhances the tests for TabletEventConverterEvdev to support different device characteristics by loading the device properties from a DeviceCapabilities structure. Unfortunately I no longer have the device for which the original test was written from so this change switches the data used over to a different Wacom Tablet. This work is in preparation for tests for on-screen active stylus devices which will have different device properties. The new data highlighted a bug in TabletEventConverterEvdev where we were failing to zero the initial absolute position. TEST=events_unittests passes. BUG=448467 R=spang@chromium.org Committed: https://crrev.com/ef110c2c94def1c158361f0863ffc93853d36db1 Cr-Commit-Position: refs/heads/master@{#330948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -77 lines) Patch
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 17 chunks +126 lines, -77 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
robert.bradford
5 years, 7 months ago (2015-05-21 16:49:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155543002/1
5 years, 7 months ago (2015-05-21 16:57:33 UTC) #3
spang
lgtm
5 years, 7 months ago (2015-05-21 16:57:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-21 17:40:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155543002/1
5 years, 7 months ago (2015-05-21 17:42:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 17:47:32 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 17:48:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef110c2c94def1c158361f0863ffc93853d36db1
Cr-Commit-Position: refs/heads/master@{#330948}

Powered by Google App Engine
This is Rietveld 408576698