Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: appengine/chromium_rietveld/new_static/model/patch_set.js

Issue 1155513002: [Rietveld] Add support for patchset dependencies (Closed) Base URL: https://chromium.googlesource.com/infra/infra@master
Patch Set: Fix lint issues in test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/chromium_rietveld/new_static/model/patch_set.js
diff --git a/appengine/chromium_rietveld/new_static/model/patch_set.js b/appengine/chromium_rietveld/new_static/model/patch_set.js
index 65be9154604feef295feb2991fcef39d20b301ba..6c68ead90db18271e79bca89b13ec585f392c11a 100644
--- a/appengine/chromium_rietveld/new_static/model/patch_set.js
+++ b/appengine/chromium_rietveld/new_static/model/patch_set.js
@@ -23,6 +23,8 @@ function PatchSet(issue, id, sequence)
this.cqDryRun = false;
this.mostRecent = false;
this.active = false;
+ this.dependsOnPatchset = null;
+ this.dependentPatchsets = null; // Array<PatchSet>
Object.preventExtensions(this);
}
@@ -30,6 +32,14 @@ PatchSet.DETAIL_URL = "/api/{1}/{2}/?comments=true&try_jobs=false";
PatchSet.REVERT_URL = "/api/{1}/{2}/revert";
PatchSet.DELETE_URL = "/{1}/patchset/{2}/delete";
PatchSet.TITLE_URL = "/{1}/patchset/{2}/edit_patchset_title";
+PatchSet.PATCHSET_URL = "/{1}/#ps{2}";
+
+PatchSet.prototype.getPatchsetUrl = function()
+{
+ return PatchSet.PATCHSET_URL.assign(
+ encodeURIComponent(this.issue.id),
+ encodeURIComponent(this.id));
+};
PatchSet.prototype.getDetailUrl = function()
{
@@ -123,6 +133,22 @@ PatchSet.prototype.parseData = function(data)
this.title = data.message || "";
this.lastModified = Date.utc.create(data.modified);
this.created = Date.utc.create(data.created);
+ if (data.depends_on_patchset) {
+ var tokens = data.depends_on_patchset.split(":");
+ var dependsOnIssue = new Issue(parseInt(tokens[0]));
+ dependsOnIssue.loadDetails();
+ this.dependsOnPatchset = new PatchSet(dependsOnIssue, parseInt(tokens[1]), 0);
+ }
+ if (data.dependent_patchsets && data.dependent_patchsets.length != 0) {
+ this.dependentPatchsets = [];
+ data.dependent_patchsets.forEach(function(dependent_patchset, i) {
+ var tokens = dependent_patchset.split(":");
+ var dependentIssue = new Issue(parseInt(tokens[0]));
+ dependentIssue.loadDetails();
+ var dependentPatchset = new PatchSet(dependentIssue, parseInt(tokens[1]), i + 1);
+ this.dependentPatchsets.push(dependentPatchset);
+ }, this);
+ }
Object.keys(data.files || {}, function(name, value) {
var file = new PatchFile(patchset, name);

Powered by Google App Engine
This is Rietveld 408576698