Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html

Issue 1155513002: [Rietveld] Add support for patchset dependencies (Closed) Base URL: https://chromium.googlesource.com/infra/infra@master
Patch Set: Make get_depends_on_patchset return JSON instead of text Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html
diff --git a/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html b/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html
index ad4fc964c077ebb2c5b1fcd45a1df0b2f1752f76..ec1293b8a98aa723acddc996574d40a3f4b664a8 100644
--- a/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html
+++ b/appengine/chromium_rietveld/new_static/components/cr-issue-patchset.html
@@ -64,6 +64,32 @@ found in the LICENSE file. -->
</template>
</div>
</template>
+ <template if="{{ patchset.dependsOnPatchset }}">
+ <div id="depends-on-patchset">
+ <h2>
+ Depends on Patchset
+ </h2>
+ <div class="{{ { linethrough: patchset.dependsOnPatchset.issue.closed } | tokenList }}">
+ <a class="view-depends-on-patchset" href="{{ patchset.dependsOnPatchset | getPatchsetUrl }}" target="_blank">
+ {{ patchset.dependsOnPatchset | getPatchsetUrl }}
jrobbins 2015/06/09 17:23:08 Rather than displaying the patchset URL as the lin
rmistry 2015/06/10 12:43:30 Done. I also staged it on skia-codereview-staging
+ </a>
+ </div>
+ </div>
+ </template>
+ <template if="{{ patchset.dependentPatchsets }}">
+ <div id="dependent-patchsets">
+ <h2>
+ Dependent Patchsets
+ </h2>
+ <template repeat="{{ dependentPatchset in patchset.dependentPatchsets }}">
+ <div class="{{ { linethrough: dependentPatchset.issue.closed } | tokenList }}">
+ <a class="view-dependent-patchsets" href="{{ dependentPatchset | getPatchsetUrl }}" target="_blank">
+ {{ dependentPatchset | getPatchsetUrl }}
+ </a>
+ </div>
+ </template>
+ </div>
+ </template>
<div id="dialogs"></div>
</template>
<script>
@@ -95,6 +121,9 @@ found in the LICENSE file. -->
console.log(e);
});
},
+ getPatchsetUrl: function(patchset) {
+ return patchset.getPatchsetUrl();
+ },
getFiles: function() {
// TODO(esprehn): Use an id instead.
return this.shadowRoot.querySelectorAll("cr-issue-patchfile").array();

Powered by Google App Engine
This is Rietveld 408576698