chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html - Issue 11555033: Adding local html page used in Instant Extended mode when instant is disabled or unavailable.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.html

Issue 11555033: Adding local html page used in Instant Extended mode when instant is disabled or unavailable. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addressing samarth's and sky's comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css ('K') | « chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css ('k') | chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js » ('j') | chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <!-- Copyright 2012 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.
	Evan Stade 2012/12/14 01:09:25 we seem to have a different style (or no header at we seem to have a different style (or no header at all) in each html file :( Shishir 2012/12/14 03:46:52 I saw them in some, and copied this one from: net Show quoted text On 2012/12/14 01:09:25, Evan Stade wrote: > we seem to have a different style (or no header at all) in each html file :( I saw them in some, and copied this one from: net_internals/help.html Would you rather I removed this?
	6 -->

	7 <head>

	8 <script src='chrome://resources/js/util.js'></script>

	9 <script src='chrome://local-omnibox-popup/local_omnibox_popup.js'></script>

	10 <link rel='stylesheet'

	11 href='chrome://local-omnibox-popup/local_omnibox_popup.css'></link>
	Evan Stade 2012/12/14 01:09:25 don't align attributes, just indent 4 spaces don't align attributes, just indent 4 spaces Shishir 2012/12/14 03:46:52 Done. Show quoted text On 2012/12/14 01:09:25, Evan Stade wrote: > don't align attributes, just indent 4 spaces Done.
	12 </head>

	13 <body>

	14 <div id='suggestionsBox'>
	Evan Stade 2012/12/14 01:09:25 nit: double quotes in html, single quotes in css a nit: double quotes in html, single quotes in css and js Shishir 2012/12/14 03:46:52 Done. Show quoted text On 2012/12/14 01:09:25, Evan Stade wrote: > nit: double quotes in html, single quotes in css and js Done.
	15 </div>
	Evan Stade 2012/12/14 01:09:25 nit: you can put </div> on same line as <div> nit: you can put </div> on same line as <div> Shishir 2012/12/14 03:46:52 Done. Show quoted text On 2012/12/14 01:09:25, Evan Stade wrote: > nit: you can put </div> on same line as <div> Done.
	16 </body>

	17 </html>

OLD	NEW