chrome/common/url_constants.h - Issue 11555033: Adding local html page used in Instant Extended mode when instant is disabled or unavailable.

Side by Side Diff: chrome/common/url_constants.h

Issue 11555033: Adding local html page used in Instant Extended mode when instant is disabled or unavailable. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/webui/local_omnibox_popup/local_omnibox_popup_ui.cc ('K') | « chrome/chrome_browser_ui.gypi ('k') | chrome/common/url_constants.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Contains constants for known URLs and portions thereof.	5 // Contains constants for known URLs and portions thereof.

6	6

7 #ifndef CHROME_COMMON_URL_CONSTANTS_H_	7 #ifndef CHROME_COMMON_URL_CONSTANTS_H_

8 #define CHROME_COMMON_URL_CONSTANTS_H_	8 #define CHROME_COMMON_URL_CONSTANTS_H_

9	9

10 #include "build/build_config.h"	10 #include "build/build_config.h"

(...skipping 154 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
165 extern const char kChromeUIIPCHost[];	165 extern const char kChromeUIIPCHost[];

166 extern const char kChromeUIKeyboardHost[];	166 extern const char kChromeUIKeyboardHost[];

167 extern const char kChromeUIKillHost[];	167 extern const char kChromeUIKillHost[];

168 extern const char kChromeUIMediaInternalsHost[];	168 extern const char kChromeUIMediaInternalsHost[];

169 extern const char kChromeUIMemoryHost[];	169 extern const char kChromeUIMemoryHost[];

170 extern const char kChromeUIMemoryRedirectHost[];	170 extern const char kChromeUIMemoryRedirectHost[];

171 extern const char kChromeUIMetroFlowHost[];	171 extern const char kChromeUIMetroFlowHost[];

172 extern const char kChromeUINaClHost[];	172 extern const char kChromeUINaClHost[];

173 extern const char kChromeUINetInternalsHost[];	173 extern const char kChromeUINetInternalsHost[];

174 extern const char kChromeUINewTabHost[];	174 extern const char kChromeUINewTabHost[];

	175 extern const char kChromeUILocalOmniboxPopupHost[];
	samarth 2012/12/13 00:58:21 Can we just use this constant (or another constant Can we just use this constant (or another constant defined in this file) instead of defining a second constant in InstantController? At the very least, it shouldn't be possible for the two to get out of sync as is the case right now. Shishir 2012/12/13 22:57:58 As discussed this is hard to do since we are not a Show quoted text On 2012/12/13 00:58:21, samarth wrote: > Can we just use this constant (or another constant defined in this file) instead > of defining a second constant in InstantController? > > At the very least, it shouldn't be possible for the two to get out of sync as is > the case right now. As discussed this is hard to do since we are not allowed static string members.
175 extern const char kChromeUIOmniboxHost[];	176 extern const char kChromeUIOmniboxHost[];

176 extern const char kChromeUIPerformanceMonitorHost[];	177 extern const char kChromeUIPerformanceMonitorHost[];

177 extern const char kChromeUIPluginsHost[];	178 extern const char kChromeUIPluginsHost[];

178 extern const char kChromeUIPolicyHost[];	179 extern const char kChromeUIPolicyHost[];

179 extern const char kChromeUIPredictorsHost[];	180 extern const char kChromeUIPredictorsHost[];

180 extern const char kChromeUIPrintHost[];	181 extern const char kChromeUIPrintHost[];

181 extern const char kChromeUIProfilerHost[];	182 extern const char kChromeUIProfilerHost[];

182 extern const char kChromeUIQuotaInternalsHost[];	183 extern const char kChromeUIQuotaInternalsHost[];

183 extern const char kChromeUIResourcesHost[];	184 extern const char kChromeUIResourcesHost[];

184 extern const char kChromeUISessionFaviconHost[];	185 extern const char kChromeUISessionFaviconHost[];

(...skipping 234 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
419 // Parameters that get appended to force SafeSearch.	420 // Parameters that get appended to force SafeSearch.

420 extern const char kSafeSearchSafeParameter[];	421 extern const char kSafeSearchSafeParameter[];

421 extern const char kSafeSearchSsuiParameter[];	422 extern const char kSafeSearchSsuiParameter[];

422	423

423 // The URL for the "Learn more" link in the media access infobar.	424 // The URL for the "Learn more" link in the media access infobar.

424 extern const char kMediaAccessLearnMoreUrl[];	425 extern const char kMediaAccessLearnMoreUrl[];

425	426

426 } // namespace chrome	427 } // namespace chrome

427	428

428 #endif // CHROME_COMMON_URL_CONSTANTS_H_	429 #endif // CHROME_COMMON_URL_CONSTANTS_H_

OLD	NEW