Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1155503003: Adjust GetPropertyWithFailedAccessCheck to support elements (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adjust GetPropertyWithFailedAccessCheck to support elements BUG=v8:4137 LOG=n Committed: https://crrev.com/10329be641f2cb832ec2129f61e71fe311a10620 Cr-Commit-Position: refs/heads/master@{#28559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/objects.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-21 14:26:29 UTC) #2
Jakob Kummerow
lgtm
5 years, 7 months ago (2015-05-21 14:47:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155503003/1
5 years, 7 months ago (2015-05-21 14:48:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 15:25:02 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 15:25:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10329be641f2cb832ec2129f61e71fe311a10620
Cr-Commit-Position: refs/heads/master@{#28559}

Powered by Google App Engine
This is Rietveld 408576698