Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 1155503002: [turbofan] Prepare mechanism to enable TF on language subset. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Prepare mechanism to enable TF on language subset. This allows enabling TurboFan on a certain subset of language features in the AstNumberingVisitor. The heuristics of when to optimize remain unchanged, only the choice of which optimizing compiler to use changes. R=bmeurer@chromium.org BUG=v8:4131 LOG=N Committed: https://crrev.com/54b34bdd33e2bdc9169c363655796fba6feb0a09 Cr-Commit-Position: refs/heads/master@{#28544}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix think'o! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M src/ast.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast-numbering.cc View 1 5 chunks +11 lines, -4 lines 0 comments Download
M src/compiler.cc View 3 chunks +4 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 7 months ago (2015-05-21 10:49:05 UTC) #1
Benedikt Meurer
LGTM. https://codereview.chromium.org/1155503002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/1155503002/diff/1/src/compiler.cc#newcode380 src/compiler.cc:380: (dont_crankshaft && strcmp(FLAG_turbo_filter, "~~") == 0) || This ...
5 years, 7 months ago (2015-05-21 10:55:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155503002/20001
5 years, 7 months ago (2015-05-21 11:25:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 11:41:20 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 11:41:35 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54b34bdd33e2bdc9169c363655796fba6feb0a09
Cr-Commit-Position: refs/heads/master@{#28544}

Powered by Google App Engine
This is Rietveld 408576698