chrome/android/java/res/layout/js_modal_dialog.xml - Issue 11555004: Refactoring JavaScript modal dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/js_modal_dialog.xml

Issue 11555004: Refactoring JavaScript modal dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved.	2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <!--	8 <!--

9 Defines all the widgets that each of the types of JS modal dialogs	9 Defines all the widgets that each of the types of JS modal dialogs

10 need (alerts, confirms and prompts). When we inflate the layout	10 need (alerts, confirms and prompts). When we inflate the layout

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 />	52 />

53	53

54 <CheckBox android:id="@+id/suppress_js_modal_dialogs"	54 <CheckBox android:id="@+id/suppress_js_modal_dialogs"

55 android:textAppearance="?android:attr/textAppearanceSmall"	55 android:textAppearance="?android:attr/textAppearanceSmall"

56 android:layout_width="match_parent"	56 android:layout_width="match_parent"

57 android:layout_height="wrap_content"	57 android:layout_height="wrap_content"

58 android:text="@string/suppress_js_modal_dialogs"	58 android:text="@string/suppress_js_modal_dialogs"

59 android:layout_gravity="left"	59 android:layout_gravity="left"

60 />	60 />

61	61

62 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

63 android:layout_width="match_parent"

64 android:layout_height="wrap_content"

65 android:orientation="horizontal"

66 >

67 <Button android:id="@+id/js_modal_dialog_button_cancel"

68 android:layout_width="wrap_content"

69 android:layout_height="wrap_content"

70 android:text="@string/js_modal_dialog_cancel"

71 android:layout_weight="1"

72 />

73 <Button android:id="@+id/js_modal_dialog_button_confirm"

74 android:layout_width="wrap_content"

75 android:layout_height="wrap_content"

76 android:text="@string/js_modal_dialog_confirm"

77 android:layout_weight="1"

78 />

79 </LinearLayout>

80 </LinearLayout>	62 </LinearLayout>

81 </ScrollView>	63 </ScrollView>

OLD	NEW