Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1155493007: Micro benchmark for Try-Catch-Finally (Closed)

Created:
5 years, 6 months ago by Michael Hablich
Modified:
5 years, 6 months ago
CC:
v8-dev, rossberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Micro benchmark for Try-Catch-Finally BUG=v8:4131 LOG=n Committed: https://crrev.com/994eb59dcd757eb71f047ce6e765107201a87314 Cr-Commit-Position: refs/heads/master@{#28789}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed formatting nit #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -2 lines) Patch
A + test/js-perf-test/Exceptions/run.js View 1 chunk +2 lines, -2 lines 0 comments Download
A test/js-perf-test/Exceptions/try-catch.js View 1 1 chunk +108 lines, -0 lines 6 comments Download
M test/js-perf-test/JSTests.json View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Hablich
5 years, 6 months ago (2015-06-03 09:59:44 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1155493007/diff/1/test/js-perf-test/Exceptions/try-catch.js File test/js-perf-test/Exceptions/try-catch.js (right): https://codereview.chromium.org/1155493007/diff/1/test/js-perf-test/Exceptions/try-catch.js#newcode5 test/js-perf-test/Exceptions/try-catch.js:5: new BenchmarkSuite( 'Try-Catch', [1000], [ nit: Dangling white-space ...
5 years, 6 months ago (2015-06-03 11:06:21 UTC) #3
Michael Hablich
https://codereview.chromium.org/1155493007/diff/1/test/js-perf-test/Exceptions/try-catch.js File test/js-perf-test/Exceptions/try-catch.js (right): https://codereview.chromium.org/1155493007/diff/1/test/js-perf-test/Exceptions/try-catch.js#newcode5 test/js-perf-test/Exceptions/try-catch.js:5: new BenchmarkSuite( 'Try-Catch', [1000], [ On 2015/06/03 11:06:21, Michael ...
5 years, 6 months ago (2015-06-03 11:16:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155493007/20001
5 years, 6 months ago (2015-06-03 11:31:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-03 12:12:27 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/994eb59dcd757eb71f047ce6e765107201a87314 Cr-Commit-Position: refs/heads/master@{#28789}
5 years, 6 months ago (2015-06-03 12:12:43 UTC) #9
arv (Not doing code reviews)
https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Exceptions/try-catch.js File test/js-perf-test/Exceptions/try-catch.js (right): https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Exceptions/try-catch.js#newcode16 test/js-perf-test/Exceptions/try-catch.js:16: WithFinallyOnException, WithFinallyOnExceptionSetup, WithFinallyOnExceptionTearDown) Long line https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Exceptions/try-catch.js#newcode26 test/js-perf-test/Exceptions/try-catch.js:26: var a ...
5 years, 6 months ago (2015-06-03 14:10:00 UTC) #10
Michael Hablich
5 years, 6 months ago (2015-06-03 14:26:48 UTC) #12
Message was sent while issue was closed. 
Fixes done in https://codereview.chromium.org/1163043003

https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Excep...
File test/js-perf-test/Exceptions/try-catch.js (right):

https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Excep...
test/js-perf-test/Exceptions/try-catch.js:16: WithFinallyOnException,
WithFinallyOnExceptionSetup, WithFinallyOnExceptionTearDown)
On 2015/06/03 14:10:00, arv wrote:
> Long line

Done.

https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Excep...
test/js-perf-test/Exceptions/try-catch.js:26: var a = 4;
On 2015/06/03 14:10:00, arv wrote:
> What is the point of this setup function? It creates local variables that are
> never used.

*facepalm* fixed.

https://codereview.chromium.org/1155493007/diff/20001/test/js-perf-test/Excep...
test/js-perf-test/Exceptions/try-catch.js:40: return c === 10;
On 2015/06/03 14:10:00, arv wrote:
> This will return false because c is NaN

Done.

Powered by Google App Engine
This is Rietveld 408576698