Index: chrome/browser/notifications/platform_notification_service_impl.cc |
diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc |
index 56908d85b8691880bd8035162cc15555a6b986cf..e86a90fb61b79cf3ba8398b473866674bd468a9d 100644 |
--- a/chrome/browser/notifications/platform_notification_service_impl.cc |
+++ b/chrome/browser/notifications/platform_notification_service_impl.cc |
@@ -4,6 +4,7 @@ |
#include "chrome/browser/notifications/platform_notification_service_impl.h" |
+#include "base/metrics/histogram_macros.h" |
#include "base/prefs/pref_service.h" |
#include "base/strings/utf_string_conversions.h" |
#include "chrome/browser/browser_process.h" |
@@ -52,15 +53,16 @@ namespace { |
// Callback to provide when deleting the data associated with persistent Web |
// Notifications from the notification database. |
void OnPersistentNotificationDataDeleted(bool success) { |
- // TODO(peter): Record UMA for notification deletion requests created by the |
- // PlatformNotificationService. |
+ UMA_HISTOGRAM_BOOLEAN("PNS.PersistentNotificationDataDeleted", success); |
Peter Beverloo
2015/05/22 15:35:42
Oh dear. Sorry, I typed PNS as an acronym for Plat
Deepak
2015/05/23 04:41:22
Done.
|
} |
// Persistent notifications fired through the delegate do not care about the |
// lifetime of the Service Worker responsible for executing the event. |
void OnEventDispatchComplete(content::PersistentNotificationStatus status) { |
- // TODO(peter): Record UMA statistics about the result status of running |
- // events for persistent Web Notifications. |
+ UMA_HISTOGRAM_ENUMERATION( |
+ "PNS.PersistentWebNotificationClickResult", status, |
+ content::PersistentNotificationStatus:: |
+ PERSISTENT_NOTIFICATION_STATUS_DATABASE_ERROR + 1); |
Peter Beverloo
2015/05/22 15:35:42
Could we add a PERSISTENT_NOTIFICATION_STATUS_MAX
Deepak
2015/05/23 04:41:22
Done.
|
} |
void CancelNotification(const std::string& id, ProfileID profile_id) { |