Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: content/public/common/persistent_notification_status.h

Issue 1155483002: Adding UMA for persistent notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changing histgram enum label. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/persistent_notification_status.h
diff --git a/content/public/common/persistent_notification_status.h b/content/public/common/persistent_notification_status.h
index b8f14094b3a5203e5c355cad5b66be397adf22ee..38d1dab4f2aa9752b19bafe342268a95ced985c5 100644
--- a/content/public/common/persistent_notification_status.h
+++ b/content/public/common/persistent_notification_status.h
@@ -8,6 +8,7 @@
namespace content {
// Delivery status for persistent notification clicks to a Service Worker.
+// PersistentNotificationStatus entries should not be reordered or removed.
enum PersistentNotificationStatus {
// The notificationclick event has been delivered successfully.
PERSISTENT_NOTIFICATION_STATUS_SUCCESS = 0,
@@ -25,6 +26,9 @@ enum PersistentNotificationStatus {
// The event could not be delivered because the data associated with the
// notification could not be read from the database.
PERSISTENT_NOTIFICATION_STATUS_DATABASE_ERROR,
+
+ // Only add new entries above this line.
+ PERSISTENT_NOTIFICATION_STATUS_MAX
};
} // content
« no previous file with comments | « chrome/browser/notifications/platform_notification_service_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698