Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: content/public/common/persistent_notification_status.h

Issue 1155483002: Adding UMA for persistent notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/persistent_notification_status.h
diff --git a/content/public/common/persistent_notification_status.h b/content/public/common/persistent_notification_status.h
index b8f14094b3a5203e5c355cad5b66be397adf22ee..82c5240e83d3805996cb4d2a9b117ae68642af5c 100644
--- a/content/public/common/persistent_notification_status.h
+++ b/content/public/common/persistent_notification_status.h
@@ -8,6 +8,7 @@
namespace content {
// Delivery status for persistent notification clicks to a Service Worker.
+// NotificationStatus entries should not be reordered or removed.
Peter Beverloo 2015/05/27 12:28:48 nit: Either "PersistentNotificationStatus entries
Deepak 2015/05/27 12:42:38 Done.
enum PersistentNotificationStatus {
// The notificationclick event has been delivered successfully.
PERSISTENT_NOTIFICATION_STATUS_SUCCESS = 0,
@@ -25,6 +26,8 @@ enum PersistentNotificationStatus {
// The event could not be delivered because the data associated with the
// notification could not be read from the database.
PERSISTENT_NOTIFICATION_STATUS_DATABASE_ERROR,
+
+ PERSISTENT_NOTIFICATION_STATUS_MAX
Peter Beverloo 2015/05/27 12:28:48 nit: Please add a comment above this line saying:
Deepak 2015/05/27 12:42:38 Done.
};
} // content

Powered by Google App Engine
This is Rietveld 408576698