Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: pkg/analyzer/lib/src/task/dart_work_manager.dart

Issue 1155473003: Don't schedule LIBRARY_ERRORS_READY for libraries that should not be analyzed. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | pkg/analyzer/test/generated/engine_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/dart_work_manager.dart
diff --git a/pkg/analyzer/lib/src/task/dart_work_manager.dart b/pkg/analyzer/lib/src/task/dart_work_manager.dart
index e006f86e5d0e11c8edf0f157b30d2d9f4c663881..32edf26fea5cb1215fb311dca7ea25e149ec4f42 100644
--- a/pkg/analyzer/lib/src/task/dart_work_manager.dart
+++ b/pkg/analyzer/lib/src/task/dart_work_manager.dart
@@ -12,6 +12,7 @@ import 'package:analyzer/src/generated/engine.dart'
AnalysisEngine,
AnalysisErrorInfo,
AnalysisErrorInfoImpl,
+ AnalysisOptions,
CacheState,
InternalAnalysisContext;
import 'package:analyzer/src/generated/error.dart';
@@ -254,7 +255,8 @@ class DartWorkManager implements WorkManager {
SourceKind kind = outputs[SOURCE_KIND];
if (kind != null) {
unknownSourceQueue.remove(target);
- if (kind == SourceKind.LIBRARY) {
+ if (kind == SourceKind.LIBRARY &&
+ context.shouldErrorsBeAnalyzed(target, null)) {
librarySourceQueue.add(target);
}
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | pkg/analyzer/test/generated/engine_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698