Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart

Issue 1155463005: dart2js cps: Remove dart2dart from cps pipeline and clean up. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Skip tests specific to the dart backend Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/task.dart ('k') | pkg/compiler/lib/src/tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
index 24aec5ae52b6acb055ee8aeb00c766e541529883..9ce842f43367a700f4852b0efe9bd4cfa300a1fe 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart
@@ -2,8 +2,7 @@ library dart2js.unsugar_cps;
import '../../cps_ir/cps_ir_nodes.dart';
-// TODO(karlklose): share the [ParentVisitor].
-import '../../cps_ir/optimizers.dart';
+import '../../cps_ir/optimizers.dart' show ParentVisitor;
import '../../constants/expressions.dart';
import '../../constants/values.dart';
import '../../elements/elements.dart' show
@@ -124,14 +123,14 @@ class UnsugarVisitor extends RecursiveVisitor {
// body;
//
Continuation originalBody = new Continuation(<Parameter>[]);
- originalBody.body = function.body.body;
+ originalBody.body = function.body;
Continuation returnFalse = new Continuation(<Parameter>[]);
Primitive falsePrimitive = falseConstant;
returnFalse.body =
new LetPrim(falsePrimitive,
new InvokeContinuation(
- function.body.returnContinuation, <Primitive>[falsePrimitive]));
+ function.returnContinuation, <Primitive>[falsePrimitive]));
Primitive nullPrimitive = nullConstant;
Primitive test = new Identical(function.parameters.single, nullPrimitive);
@@ -144,7 +143,7 @@ class UnsugarVisitor extends RecursiveVisitor {
new IsTrue(test),
returnFalse,
originalBody))));
- function.body.body = newBody;
+ function.body = newBody;
}
/// Insert a static call to [function] at the point of [node] with result
@@ -257,8 +256,6 @@ class UnsugarVisitor extends RecursiveVisitor {
}
node.arguments.insert(0, node.receiver);
- node.callingConvention = CallingConvention.JS_INTERCEPTED;
- assert(node.isValid);
node.receiver = new Reference<Primitive>(newReceiver);
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/task.dart ('k') | pkg/compiler/lib/src/tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698