Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1155463005: dart2js cps: Remove dart2dart from cps pipeline and clean up. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Skip tests specific to the dart backend Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 6379605fcfafc158db3b7d58e526114ac8585bb8..ed8c803cbf88fab50cb10e712280b665d928326c 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -683,29 +683,9 @@ class CodeGenerator extends tree_ir.StatementVisitor
return glue.generateTypeRepresentation(node.dartType, arguments);
}
- // Dart-specific IR nodes
-
- @override
- visitReifyTypeVar(tree_ir.ReifyTypeVar node) {
- return errorUnsupportedNode(node);
- }
-
- @override
visitFunctionExpression(tree_ir.FunctionExpression node) {
- return errorUnsupportedNode(node);
- }
-
- @override
- visitFunctionDeclaration(tree_ir.FunctionDeclaration node) {
- return errorUnsupportedNode(node);
- }
-
- @override
- visitVariableDeclaration(tree_ir.VariableDeclaration node) {
- return errorUnsupportedNode(node);
- }
-
- errorUnsupportedNode(tree_ir.DartSpecificNode node) {
- throw "Unsupported node in JS backend: $node";
+ // FunctionExpressions are currently unused.
+ // We might need them if we want to emit raw JS nested functions.
+ throw 'FunctionExpressions should not be used';
}
}
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/dart_backend.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/task.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698