Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: pkg/compiler/lib/src/dart_backend/backend_ast_nodes.dart

Issue 1155463005: dart2js cps: Remove dart2dart from cps pipeline and clean up. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Skip tests specific to the dart backend Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/dart_backend/backend_ast_nodes.dart
diff --git a/pkg/compiler/lib/src/dart_backend/backend_ast_nodes.dart b/pkg/compiler/lib/src/dart_backend/backend_ast_nodes.dart
index a4d445f76522d0474dfbf8b29aef79f810871a4e..d4e86e623ebe62aacca7652e88277d910159e167 100644
--- a/pkg/compiler/lib/src/dart_backend/backend_ast_nodes.dart
+++ b/pkg/compiler/lib/src/dart_backend/backend_ast_nodes.dart
@@ -747,7 +747,7 @@ class Unparser {
}
void writeOperator(String operator) {
- write(" "); // TODO(sigurdm,kmillikin): Minimize use of whitespace.
+ write(" ");
write(operator);
write(" ");
}
@@ -787,7 +787,6 @@ class Unparser {
/// Abusing terminology slightly, the function accepts a [Receiver] which
/// may also be the [SuperReceiver] object.
void writeExp(Receiver e, int minPrecedence, {beginStmt:false}) {
- // TODO(kmillikin,sigurdm): it might be faster to use a Visitor.
void withPrecedence(int actual, void action()) {
if (actual < minPrecedence) {
write("(");
@@ -820,7 +819,6 @@ class Unparser {
write(e.name);
}
writeParameters(e.parameters);
- // TODO(sigurdm,kmillikin): Print {} for "return null;"
if (stmt is Return) {
write('=> ');
writeExp(stmt.expression, EXPRESSION);
@@ -863,8 +861,6 @@ class Unparser {
write(v.toString());
}
} else {
- // TODO(sigurdm): Use [ConstExp] to generate valid code for any
- // constant.
write(e.value.unparse());
}
} else if (e is LiteralList) {
@@ -1310,7 +1306,6 @@ class Unparser {
/// A list of string quotings that the printer may use to quote strings.
// Ignore multiline quotings for now. Would need to make sure that no
// newline (potentially prefixed by whitespace) follows the quoting.
- // TODO(sigurdm,kmillikin): Include multiline quotation schemes.
static const _QUOTINGS = const <tree.StringQuoting>[
const tree.StringQuoting(characters.$DQ, raw: false, leftQuoteLength: 1),
const tree.StringQuoting(characters.$DQ, raw: true, leftQuoteLength: 1),
@@ -1319,7 +1314,6 @@ class Unparser {
];
static StringLiteralOutput analyzeStringLiteral(Expression node) {
- // TODO(sigurdm,kmillikin): This might be a bit too expensive. Benchmark.
// Flatten the StringConcat tree.
List parts = []; // Expression or int (char node)
void collectParts(Expression e) {
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart ('k') | pkg/compiler/lib/src/dart_backend/dart_backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698