Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 1155463005: dart2js cps: Remove dart2dart from cps pipeline and clean up. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Skip tests specific to the dart backend Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
index 2d5294beb2006ee91d10bf77729bd49975cbb54c..b4bbcdc76c52a7d16ec56c9550abf0893c320101 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
@@ -54,68 +54,13 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
String name = node.element.name;
String thisParameter = formatThisParameter(node.thisParameter);
String parameters = node.parameters.map(visit).join(' ');
- String body = visit(node.body);
+ namer.setReturnContinuation(node.returnContinuation);
+ String body = indentBlock(() => visit(node.body));
return '$indentation'
'(FunctionDefinition $name $thisParameter ($parameters) return\n'
'$body)';
}
- String visitFieldDefinition(FieldDefinition node) {
- String name = node.element.name;
- if (node.body != null) {
- String body = visit(node.body);
- return '$indentation(FieldDefinition $name () return\n'
- '$body)';
- } else {
- return '$indentation(FieldDefinition $name)';
- }
- }
-
- String visitConstructorDefinition(ConstructorDefinition node) {
- String name = node.element.name;
- if (name != '') name = '$name ';
- String thisParameter = formatThisParameter(node.thisParameter);
- String parameters = node.parameters.map(visit).join(' ');
- if (node.body != null) {
- String initializers = indentBlock(() {
- return indentBlock(() {
- if (node.initializers.isEmpty) {
- return '$indentation';
- } else {
- return node.initializers.map(visit).join('\n');
- }
- });
- });
- String body = visit(node.body);
- return '$indentation'
- '(ConstructorDefinition $name$thisParameter ($parameters) return'
- ' (\n$initializers)\n$body)';
- } else {
- return '$indentation'
- '(ConstructorDefinition $name$thisParameter ($parameters) return)';
- }
- }
-
- String visitFieldInitializer(FieldInitializer node) {
- String name = node.element.name;
- String body = visit(node.body);
- return '$indentation(FieldInitializer $name\n$body)';
- }
-
- String visitSuperInitializer(SuperInitializer node) {
- String target = node.target.name;
- String selector = node.selector.name;
- String arguments =
- indentBlock(() =>
- indentBlock(() => node.arguments.map(visit).join('\n')));
- return '$indentation(SuperInitializer $target $selector (\n$arguments)';
- }
-
- String visitBody(Body node) {
- namer.setReturnContinuation(node.returnContinuation);
- return indentBlock(() => visit(node.body));
- }
-
String visitLetPrim(LetPrim node) {
String name = newValueName(node.primitive);
String value = visit(node.primitive);
@@ -263,10 +208,6 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
return '(Constant $value)';
}
- String visitReifyTypeVar(ReifyTypeVar node) {
- return '$indentation(ReifyTypeVar ${node.typeVariable.name})';
- }
-
String visitCreateFunction(CreateFunction node) {
String function =
indentBlock(() => indentBlock(() => visit(node.definition)));
@@ -309,15 +250,6 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
return '(LiteralMap ($keys) ($values))';
}
- String visitDeclareFunction(DeclareFunction node) {
- String name = visit(node.variable);
- String function = indentBlock(() => visit(node.definition));
- String body = indentBlock(() => visit(node.body));
- return '$indentation(DeclareFunction $name =\n'
- '$function in\n'
- '$body)';
- }
-
String visitIsTrue(IsTrue node) {
String value = access(node.value);
return '(IsTrue $value)';
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698