Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

chrome/browser/notifications/profile_notification.cc

Index: chrome/browser/notifications/profile_notification.cc
diff --git a/chrome/browser/notifications/profile_notification.cc b/chrome/browser/notifications/profile_notification.cc
index 745820a2ee5862b857b3f778540eab4c2b540b5a..2244299a880b792467100da1d26796341c866283 100644
--- a/chrome/browser/notifications/profile_notification.cc
+++ b/chrome/browser/notifications/profile_notification.cc
@@ -18,20 +18,18 @@ std::string ProfileNotification::GetProfileNotificationId(
                             delegate_id.c_str());
 }
 
-ProfileNotification::ProfileNotification(
-    Profile* profile,
-    const Notification& notification)
-    : profile_(profile),
+ProfileNotification::ProfileNotification(ProfileID profile_id,
+                                         const Notification& notification)
+    : profile_id_(profile_id),
       notification_(
           // Uses Notification's copy constructor to assign the message center
           // id, which should be unique for every profile + Notification pair.
-          GetProfileNotificationId(
-              notification.delegate_id(),
-              NotificationUIManager::GetProfileID(profile)),
+          GetProfileNotificationId(notification.delegate_id(), profile_id),
           notification) {
-  DCHECK(profile);
+  DCHECK(profile_id);
 #if defined(OS_CHROMEOS)
-  notification_.set_profile_id(multi_user_util::GetUserIDFromProfile(profile));
+  notification_.set_profile_id(
+      multi_user_util::GetUserIDFromProfile(profile_id));

[dewittj, 2015/05/29 16:44:30]

I'm surprised that this compiles; it takes a Profile* not a void*. 

For now, we can return the constructor to take a Profile*, but transform it into
a ProfileID for storage in the member var.

[Deepak, 2015/05/30 05:38:05]

Done.

 #endif
 }