Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5920)

Unified Diff: chrome/browser/notifications/profile_notification.h

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/profile_notification.h
diff --git a/chrome/browser/notifications/profile_notification.h b/chrome/browser/notifications/profile_notification.h
index 13952333e2ec142ee3496ea563793f6974cc4eba..1a778c805ba4cce72e9eec46d376e6604a64b6e1 100644
--- a/chrome/browser/notifications/profile_notification.h
+++ b/chrome/browser/notifications/profile_notification.h
@@ -21,15 +21,15 @@ class ProfileNotification {
static std::string GetProfileNotificationId(const std::string& delegate_id,
ProfileID profile_id);
- ProfileNotification(Profile* profile, const Notification& notification);
+ ProfileNotification(ProfileID profile_id, const Notification& notification);
~ProfileNotification();
- Profile* profile() const { return profile_; }
+ ProfileID profile() const { return profile_; }
dewittj 2015/05/22 16:54:37 nit: change to profile_id()
Deepak 2015/05/23 06:19:11 Done.
const Notification& notification() const { return notification_; }
private:
// Weak, guaranteed not to be used after profile removal by parent class.
dewittj 2015/05/22 16:54:37 please update this comment to reflect that it's ju
Deepak 2015/05/23 06:19:11 Done.
- Profile* profile_;
+ ProfileID profile_;
dewittj 2015/05/22 16:54:37 nit: change to profile_id_
Deepak 2015/05/23 06:19:11 Done.
Notification notification_;
};

Powered by Google App Engine
This is Rietveld 408576698