chrome/browser/notifications/platform_notification_service_impl.cc - Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_ui_manager_android.cc ('k') | chrome/browser/notifications/profile_notification.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_impl.cc

diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc

index be6db4c970444e312fc2fded2c7fd7479c78499d..cafd270ced855216c3d609f543e6e1052110780a 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.cc

+++ b/chrome/browser/notifications/platform_notification_service_impl.cc

@@ -320,8 +320,8 @@ bool PlatformNotificationServiceImpl::GetDisplayedPersistentNotifications(

return false; // Tests will not have a message center.

// TODO(peter): Filter for persistent notifications only.

- *displayed_notifications =

- GetNotificationUIManager()->GetAllIdsByProfile(profile);

+ *displayed_notifications = GetNotificationUIManager()->GetAllIdsByProfile(

+ NotificationUIManager::GetProfileID(profile));

return true;

#else