Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Unified Diff: chrome/browser/notifications/notification_ui_manager.h

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_ui_manager.h
diff --git a/chrome/browser/notifications/notification_ui_manager.h b/chrome/browser/notifications/notification_ui_manager.h
index 49d0ed91f95cfd81e10ff236d31815c6eaaddeb8..64c06a3d4ad717dad823c3c063919061f351b06e 100644
--- a/chrome/browser/notifications/notification_ui_manager.h
+++ b/chrome/browser/notifications/notification_ui_manager.h
@@ -67,17 +67,13 @@ class NotificationUIManager {
ProfileID profile_id) = 0;
// Returns the set of all delegate IDs for notifications from the passed
- // |profile| and |source|.
- // TODO(peter): Change Profile* to ProfileID to clarify that the profile
- // should not be used for making any calls, as it might be dead.
+ // |profile_id| and |source|.
virtual std::set<std::string> GetAllIdsByProfileAndSourceOrigin(
- Profile* profile,
+ ProfileID profile_id,
const GURL& source) = 0;
- // Returns the set of all delegate IDs for notifications from |profile|.
- // TODO(peter): Change Profile* to ProfileID to clarify that the profile
- // should not be used for making any calls, as it might be dead.
- virtual std::set<std::string> GetAllIdsByProfile(Profile* profile) = 0;
+ // Returns the set of all delegate IDs for notifications from |profile_id|.
+ virtual std::set<std::string> GetAllIdsByProfile(ProfileID profile_id) = 0;
// Removes notifications matching the |source_origin| (which could be an
// extension ID). Returns true if anything was removed.
« no previous file with comments | « chrome/browser/notifications/notification_test_util.cc ('k') | chrome/browser/notifications/notification_ui_manager_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698