Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: chrome/browser/notifications/notification_test_util.cc

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_test_util.cc
diff --git a/chrome/browser/notifications/notification_test_util.cc b/chrome/browser/notifications/notification_test_util.cc
index 1cfdf9d5c04ae209b8493623dc32fc23cb23f29f..f022cb40516784ae905e25b916a5f720f611fd2c 100644
--- a/chrome/browser/notifications/notification_test_util.cc
+++ b/chrome/browser/notifications/notification_test_util.cc
@@ -82,21 +82,21 @@ bool StubNotificationUIManager::CancelById(const std::string& delegate_id,
std::set<std::string>
StubNotificationUIManager::GetAllIdsByProfileAndSourceOrigin(
- Profile* profile,
+ ProfileID profile_id,
const GURL& source) {
std::set<std::string> delegate_ids;
for (const auto& pair : notifications_) {
- if (pair.second == profile && pair.first.origin_url() == source)
+ if (pair.second == profile_id && pair.first.origin_url() == source)
delegate_ids.insert(pair.first.delegate_id());
}
return delegate_ids;
}
std::set<std::string> StubNotificationUIManager::GetAllIdsByProfile(
- Profile* profile) {
+ ProfileID profile_id) {
std::set<std::string> delegate_ids;
for (const auto& pair : notifications_) {
- if (pair.second == profile)
+ if (pair.second == profile_id)
delegate_ids.insert(pair.first.delegate_id());
}
return delegate_ids;

Powered by Google App Engine
This is Rietveld 408576698