Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

chrome/browser/notifications/profile_notification.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/profile_notification.h"
 
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
 
 // static
 std::string ProfileNotification::GetProfileNotificationId(
     const std::string& delegate_id,
     ProfileID profile_id) {
   DCHECK(profile_id);
   return base::StringPrintf("notification-ui-manager#%p#%s",
                             profile_id,  // Each profile has its unique instance
                                          // including incognito profile.
                             delegate_id.c_str());
 }
 
-ProfileNotification::ProfileNotification(
-    Profile* profile,
-    const Notification& notification)
-    : profile_(profile),
+ProfileNotification::ProfileNotification(ProfileID profile_id,
+                                         const Notification& notification)
+    : profile_id_(profile_id),
       notification_(
           // Uses Notification's copy constructor to assign the message center
           // id, which should be unique for every profile + Notification pair.
-          GetProfileNotificationId(
-              notification.delegate_id(),
-              NotificationUIManager::GetProfileID(profile)),
+          GetProfileNotificationId(notification.delegate_id(), profile_id),
           notification) {
-  DCHECK(profile);
+  DCHECK(profile_id);
 #if defined(OS_CHROMEOS)
-  notification_.set_profile_id(multi_user_util::GetUserIDFromProfile(profile));
+  notification_.set_profile_id(
+      multi_user_util::GetUserIDFromProfile(profile_id));

[dewittj, 2015/05/29 16:44:30]

I'm surprised that this compiles; it takes a Profile* not a void*. 

For now, we can return the constructor to take a Profile*, but transform it into
a ProfileID for storage in the member var.

[Deepak, 2015/05/30 05:38:05]

Done.

 #endif
 }
 
 ProfileNotification::~ProfileNotification() {}