Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: chrome/browser/notifications/notification_ui_manager_android.cc

Issue 1155453002: Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/notifications/notification_ui_manager_android.h" 5 #include "chrome/browser/notifications/notification_ui_manager_android.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 Java_NotificationUIManager_closeNotification(env, 192 Java_NotificationUIManager_closeNotification(env,
193 java_object_.obj(), 193 java_object_.obj(),
194 persistent_notification_id, 194 persistent_notification_id,
195 origin.obj(), 195 origin.obj(),
196 tag.obj()); 196 tag.obj());
197 return true; 197 return true;
198 } 198 }
199 199
200 std::set<std::string> 200 std::set<std::string>
201 NotificationUIManagerAndroid::GetAllIdsByProfileAndSourceOrigin( 201 NotificationUIManagerAndroid::GetAllIdsByProfileAndSourceOrigin(
202 Profile* profile, 202 ProfileID profile_id,
203 const GURL& source) { 203 const GURL& source) {
204 NOTREACHED(); 204 NOTREACHED();
205 return std::set<std::string>(); 205 return std::set<std::string>();
206 } 206 }
207 207
208 std::set<std::string> NotificationUIManagerAndroid::GetAllIdsByProfile( 208 std::set<std::string> NotificationUIManagerAndroid::GetAllIdsByProfile(
209 Profile* profile) { 209 ProfileID profile_id) {
210 NOTREACHED(); 210 NOTREACHED();
211 return std::set<std::string>(); 211 return std::set<std::string>();
212 } 212 }
213 213
214 bool NotificationUIManagerAndroid::CancelAllBySourceOrigin( 214 bool NotificationUIManagerAndroid::CancelAllBySourceOrigin(
215 const GURL& source_origin) { 215 const GURL& source_origin) {
216 NOTREACHED(); 216 NOTREACHED();
217 return false; 217 return false;
218 } 218 }
219 219
220 bool NotificationUIManagerAndroid::CancelAllByProfile(ProfileID profile_id) { 220 bool NotificationUIManagerAndroid::CancelAllByProfile(ProfileID profile_id) {
221 NOTREACHED(); 221 NOTREACHED();
222 return false; 222 return false;
223 } 223 }
224 224
225 void NotificationUIManagerAndroid::CancelAll() { 225 void NotificationUIManagerAndroid::CancelAll() {
226 NOTREACHED(); 226 NOTREACHED();
227 } 227 }
228 228
229 bool NotificationUIManagerAndroid::RegisterNotificationUIManager(JNIEnv* env) { 229 bool NotificationUIManagerAndroid::RegisterNotificationUIManager(JNIEnv* env) {
230 return RegisterNativesImpl(env); 230 return RegisterNativesImpl(env);
231 } 231 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698